STCOM-1397 transpile on publish #2413
Draft
+1,316
−299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transpile on publish. Leverage the `prepare` npm lifecycle hook to execute transpilationi prior to publishing. Relocate `hooks` and `utils` into `lib` to simplify transpilation and follow JS SOP. This required updates to some import paths but no substantive changes otherwise. In `lib/util/currencies`, the import that pulls in currency data changed because ... it's not really clear, except the previous import did not work and the updated import looks a little simpler. 🤷 unrelated cleanup: * remove unused file `Jenkinsfile.deprecated` * clean up `package.json`: * remove `engines` * correctly specify `repository` Refs STCOM-1397
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transpile on publish. Leverage the
preparenpm lifecycle hook to execute transpilationi prior to publishing. Relocatehooksandutilsintolibto simplify transpilation and follow JS SOP. This required updates to some import paths but no substantive changes otherwise.In
lib/util/currencies, the import that pulls in currency data changed because ... it's not really clear, except the previous import did not work and the updated import looks a little simpler. 🤷unrelated cleanup:
Jenkinsfile.deprecatedpackage.json:enginesrepositoryRefs STCOM-1397